Holochain code review

cryptobriefing.com/holochain-code-review-and-distributed-computing-thoughts/

>First impressions, this is really good code. New standard kind of good.

>A lot of production considerations already in. This code is scary good.

>I love this code. File after file after file is just amazing. I’m going to be spending a lot more time here.

>Guys, this is something else, after seeing the above code, I started exploring a bit more. Clutter, a fully distributed twitter built on holochain. Holo Vault, built in permissioned, user controlled KYC. Just because. Holochat, a distributed Slack. This is actually insane. There is so much here already. Everyone is going on about the new distributed Internet, here it is. Ready to be used.

This is something entirely new, and it isn’t a blockchain, this is a new kind of decentralized beast, but I love it.

Any programmerfags can confirm his comments?
This is a pretty reputable site and have never been accused of paid reviews.

Attached: 1_h2fQ2Xko-gbN447HG2TnkA.png (1600x1066, 45K)

Other urls found in this thread:

medium.com/h-o-l-o/why-theres-no-vesting-in-the-holo-ico-feb4f180e8b2
github.com/holochain/holochain-proto
github.com/holochain
google.co.uk/amp/s/cryptobriefing.com/amp/tron-plagiarism-investor-lawsuit
github.com/holochain/holochain-proto/blob/develop/ui/webserver.go
twitter.com/NSFWRedditImage

So why do you guys abandon every thread this gets posted in?

Attached: 1534025659947.png (850x492, 196K)

Because that pic a fake FUD

tired of this lowest grade fud. Literally a telegram admin used a poor choice of words to describe binances long term support for holofuel integration. link me an official announcement and ill stfu.

its not fake retard

>ImpLYING

This is the only piece of fud you've got for HOT and it's not even true.

SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL SELL

Attached: 1526686291535.png (280x291, 88K)

alright here some higher grade fud. why didnt the team vest their ico tokens faggot? you realise they are dumping on your asses every minute?

>muh bills to pay they say
oh sweet so where the fuck are the 20m$ you raised in ether money?

never invest into coins without vesting you dumb biztards

.10 eoy

OH NO NO NO

how can you not invest in this trap? godam

Feetcoin

medium.com/h-o-l-o/why-theres-no-vesting-in-the-holo-ico-feb4f180e8b2

Also, most of the teams supply was spent on backpay, loans, partners etc. so they don't hold close to 25% anyway.

>Literally a Telegram admin
>DIRECTOR OF MARKETING
Link me to an official announcement from Binance.

Is "Sami" a man?

Attached: XT9zQxZQgTL0VMCyO8jkINlb2HDTac7BfQq41aXE-179x179.jpg (179x179, 9K)

Ain't nothing wrong with that

Attached: 15339501026413.jpg (2048x1161, 1.03M)

You have no proof that the team is dumping anything and if they are it's not having an effect. Bonobo tier fud.

>a blockchain that is secured without paying for security! thermodynamics was bunk all along!

>a blockchain where nodes dont need to be synced! consensus was never actually important!

i could go on, but how do faggots fall for this shit?

Agent-centric

>a blockchain
it's not a blockchain

Because there's different types of consensus that can be used to get efficiency instead of requiring the entire fucking network reach a consensus on every single fucking transaction when it's not necessary, which is what kills ETH and BTC. That's why literally every third gen. blockchain/crypto project is trying to get away from the dead end of global consensus.

>First impressions, this is really good code. New standard kind of good.
>Guys, this is something else, after seeing the above code, I started exploring a bit more. Clutter, a fully distributed twitter built on holochain. Holo Vault, built in permissioned, user controlled KYC. Just because. Holochat, a distributed Slack. This is actually insane. There is so much here already. Everyone is going on about the new distributed Internet, here it is. Ready to be used.
*Breathes in*
*Breathes out*
*aaaaaahhhh...*
I love it when an article is so transparently pageety that you don't even have to bother researching the project yourself.
Thanks biz, seriously.

Attached: 1533947307206.jpg (573x430, 41K)

thats what sharding is for retard. getting rid of global consensus sacrifices security

ok, can you check the code and tell my why he's wrong? or is it literally impossible that a groundbreaking piece of software is created in the crypto space. cryptobriefing and andre cronje are quite reputable

Holoscam with decentralised internet/Tor but no working proof of concept

I don't even need to, senpai. The overwhelming stench of curry from that article is all I need.

exactly this. holo is dogshit

>no working proof of concept
an alpha release and is available for public testing and use
github.com/holochain/holochain-proto
there are also several prototype and proof-of-concept holochain apps available for download
github.com/holochain

NEXT

That is actually feet you are smelling

And this is different to Skyscam how?
It’s run by the same people under a different name

That would be hilarious

lambao

Look at all the other projects this guy reviewed. I don't recognize a single name in there.

>Bagholders from two different scam coins constantly fighting
>Synth accidentally posts a family photo
>it's Brock, Jabba the feet and him at a park together
>Both teams exit scam within hours as the news comes out that they are a family of scammers
Great lore for two shitcoins.

Dude he has looked at just about all the well known projects in existence. He hates nearly all of them. This is the real shit....the code....not the chink pr bs.....not the billion ico bs....the actual code. 95% is shit and even straight calls out Tron for copy pasta. When the fust settles un crypto these fake projects will die.

google.co.uk/amp/s/cryptobriefing.com/amp/tron-plagiarism-investor-lawsuit

can it reach 10 cents in a ultra golden bull run?

If BTC goes to 50K it will go past 30 cents easily. I’m thinking it could top at .40-.50 cents

Thank you for being a voice of reason. The assume everything is fake, everyone is paid, nothing is real... Except it is real. I have been watching this argument for 4 months. Not a single dev/programmer has come out saying the code is fake or that its impossible to operate. There have only been concerns of security and certain scaling aspects. Honestly the real fud is speculation and doubt at best right now.

Shit talk all you want guys. Us holochads saved our gains by switching to Holo 4 months ago. And even many of the newcomers have made mucho gains. You can deny and shit talk all you want while you hold your bleeding altcoins and feel jealous and salty.

Don't be a hater. It's bad for you.

Try thinking outside the blocks

source: your asshole

biz is so salty from getting justed for half a year straight they refuse to believe anything positive no matter how clear cut it is. topkek

oh god. i had 172 MILLION hot at one point. i sold them and traded shitcoins and lost almost everything. went all in on holo again but now i only have 15 million. oh man. DAMNNN. sigh. well i guess 15 million euros is ok. ill settle with that.

Haha you think that matters. No one ever calls out these shitheaps for being fake. Even the most blatant scams I never see a proper deconstruction.
I guess no one gives a fuck really.

Why do you post this article, its from andrew ancheta. A different person than who wrote the holo shill article, andre cronje. Are you trying to mislead everyone into thinking that everything on the cryptobriefing site is from the same person?

cz_biance never tweeted that. i went to his twitter and looked. it's not there. this is FUD so he can buy holochain cheaper.

So desperate holocucks. If you could control yourself from lying all the time, your chances would be better.

Holo Fud makes me bullish. Ive never seen such obvious intentions to pull the price down to buy cheap on a project.

I have made it clear I am a fundamentals investor and have seen very little to nothing to make me scared. I went all in on Holo and it saved my ass. And considering how its at around 10 sats... you know it's going to 100 sats eventually. We will at least hit 500m-1bill market cap before the network even launches.

Holo fud is weird, the same couple guys saying stupid shit that gets disapproved and they keep going in each thread

What makes it even more humorous is the fact that the price is super low now. They intentionally started the price where it is and that's great. Why do iPhones cost as much as they do if other phones can do the same thing? Because iPhones aren't other phones and in a society with capitalism at the helm, you can charge as much as you want for your product. But this is on another level when you look at the code and you do some evaluation of the team and goals they have. Not stupid people involved in Holochain. You know that Eric Harris-Braun's wife passed away and why that's significant? He enjoyed his time with her and his son is also involved in this. You have nothing to lose when you've lived the kind of life he's lived. Coding since the 80s and same with Art Brock. Wonder why it was kept under the radar for so long.

Ethereum was less than $0.50 before. This one can grow exponentially too. I am excited to take part in this and I hope you all do as well. Crypto is beginning to show its true colors.

Attached: HolochainHDpoweron.gif (300x300, 649K)

KEEP SHILLING YOUR BAGS FAGGOT

NOBODY CARES ABOUT CRYPTOBRIEFING ANYWAY, ICO DAYS ARE OVER

Hey retards, HOLOCHAIN DOES NOT NEED A COIN.

>fundamentals investor
>in crypto
>holo guaranteed 10x
>5-10x before network launches
>2018

That review is a total scam.

Code samples he is salivating over are basic plumbing. Literally no important logic is found there. It's like reading a review of a house where the reviewer claims that the house is built "scary good" while inspecting some mediocre postboxes in front.

Either the reviewer has learned to code 3 weeks ago or is an experienced coder trolling. Hard to say which is which.

And the sampled code is competent at best. Nothing special.

well what’s your opinion then?

it's irrelevant, they rewrote it all in Rust

>So why do you guys abandon every thread this gets posted in?
He's referring to Skycoin fool.

My opinion is "meh".

I'm not going to bother doing a review myself because I have better things to do with my life, but the opnion expressed in the review itself is total bullshit.

The code samples in the review are mediocre - some of the stuff there is actually bad - for example splitting strings to get port numbers out, which by itself is nothing too wrong. BUT you usually encapsulate that shit into proper objects before consuming. The way it's done there is not what one would call "elegant". In fact it's lazy. A sign of someone either carelss or a beginner.

I'm not judging the platform itself, just the review and the samples in the review.

>Talks shit about coders review
>Doesn't back up his opinion with any specifics
>Claims he's too busy to do a review
>Posting paragraphs on biz

Get out of here loser, you're not fooling anybody. Either back your shit up or move along. You're making yourself look stupid.

I just started buying because LISP

I providen an example of shitty programming. Improve your reading comprehension.

Anyway, this this is an engineering topic, so it's normal that you don't get it. You're going to have to trust me on this one. Anyone who knows their shit would see right through that "review".

Hahahahaha what a dumbass! Every penny it goes up you'd be making 1.7 million! Now every penny it goes up you'll only make 150k.

Still a lot but fuck you really fucked up

Best FUD I've seen so far honestly. The "coder" who sees through the bad code.

I don't see through bad code - I see through bullshit code reviews, which claim some basic instantiation methods are "scary good".

Go take a free programming course, maybe you'll get scammed a bit less.

>muh programmers review
everyone hipster faggot is a programmer these days

>This is a pretty reputable site
Some random crypto news site (trying to hop on the hype train) that I have never heard of before.

Especially this nigger

Well you have a point. But at the same time holo is so unique, and the ideas behind it can build so much new stuff cheaper than anything else.

It's almost a guaranteed success in my mind if they can get it to work as advertised.

>0
You seem triggered. Invested much already?

>3

Can't judge, i'm only looking at the "review" and it's "code".

>trust me, guaranteed
Holo promises so much, and this agent centric soft consensus sounds so easy. So easy until you see it happen in the real world. In reality groups often conspire against each other and the public. Holochain introduces relativistic consensus mechanics creating a new paradigm of incentivized deceit.

I think it's designed to be normie friendly so it doesn't go in depth. andre cronje seems legit if you check his background, and look at other code reviews. they have plenty of negative reviews, or examples of calling out tokens with little development "this is just another ethereum clone right now", they called out tron for plagiarism. then some are positive. this is the most positive one i've seen.

that said would still love for someone here who knows that they're talking about to give a short review of their code github.com/holochain

Holy shit that's pure mental illness

>You're going to have to trust me on this one. Anyone who knows their shit would see right through that "review".
I've yet to read anything or see anyone refute that the code is not legit. You're the one by person saying this so what makes u so special that you know so much that others don't?
Trick question, NOTHING. You don't know shit and you're just tryna hate. Keep going tho, this is top bait.

As a go engineer HAHAHAHAHAHAHAHAHAHAHAHAHAHAHA
this reviewer is embarrassing, how has he even got any attention on these reviews

> tfw when checking if a file is read only in Windows is production consideration
> tfw he ignores all the files being in root even though this means any holochain imports means you get the whole fucking codebase
> tfw the code he screenshots has fucking TODOs
> tfw he mentions interfaces as being a new standard, you know something that has been a standard for 30 fucking years

just to add, the code also has error checking that does fuck all with the error. Completely silenced errors, great work holo!

can't have shit code when your code doesn't output errors. Smart.

disregarding the review, what do you think of the code?

>if i rename user-centered into agent-centric, i'll grab the 110 iq dunning-kruger demographic
holocaustchain is the antshares of 2018, too bad for you retards this isn't 2017 anymore

any real code review and analysis takes hours and hours of looking and actually using the code. So based on that, I'm not going to say without actually spending the time.
Just from the screenshots, using interfaces is always good. The silenced errors not good and all files being in root, not good.
None of that tells me whether it's going to be a good network or not.

AWS killer confirmed, nice

I just glanced through their repo, not good. Any code base which has 4 nested layers of if/elses with muted handling just is lol

Muted handling is a PR away from being addressed (and is an obvious improvement) so that one doesn't matter.
Sometimes I prefer code that is long with nested conditionals. Messy, but if the business logic is all in one place then it's sometimes easier to understand. I dislike it when everything has to be 3-5 lines and logic is split among 10 different classes (over abstracted).

We need more coders looking into this. This is basically the best discussion on the Holo code I have seen here.

I see no PR that fixes it around every corner of the codebase. I see their last commit to develop was 26 days ago. I see over 200 issues raised with no discussion at all and no work being done.

also, any nested if's to me just scream bad design to begin with. As they're having to catch and cater for more edge scenarios that shouldn't be possible with the right design.

>I dislike it when everything has to be 3-5 lines and logic is split among 10 different classes (over abstracted).

Pajeet tier programmer detected.

Holo is to Jow Forums what ripple is to normies.

>Hurrrr it only needs to go to 0.10 and I am a millionair.

This shitcoin says it will do a shitload of things and is overdiversified. Its basically a mediocre jack of all trades and a master of none.

>Pajeet tier programmer detected.

Not pajeet and I agree it's more stylistic than anything.

github.com/holochain/holochain-proto/blob/develop/ui/webserver.go
A
This is fucking hilarious. Terrible websocket implementation. String splitting to get the endpoint URLs (hahahaha). All the handler function within the start API method.
This code is hilariously bad. It's fucking awful and looks like it was written by a post graduate who's never had any actual engineering experience.

Not pajeet just been burned by Rails magic for weeks of my life in total.

I don't see anything terrible here. You want the handlers in a second file? What's the point?

Definitely not hilariously bad...

Well you guys are shit yourselves then, or atleast aren't familiar with go. It's bad.

> No reason given
> insults
Cool I see your point now thx user

I'd check the above post which you quoted where I give numerous reasons. You're obviously not familiar with Go or building API's. Handlers should be handled with routers, you know the things that any basic Go tutorial goes into when you first learn how to build webservers with it.

Oh good point. I forgot how everything stops working if you don't use specific approved design patterns.

If you think that code is even acceptable for a project that's raised millions and is meant to decentralise the world, you need to go back to school.
All that code shows to me is complete immaturity and no real experience of managing and building large, maintainable and easily expandable systems.

Maybe we are at differing expectations. Code first and foremost needs to accomplish the objective. Anything beyond that is unimportant.
Holo's business model relies on proving the viability of the concept.
It can be rewritten, iff it needs to be.

Where is a good example then mate?

you do realize that code is just the proof of concept right?

The rust refactor is the production code