>doing code reviews
>asked guy to implement a series of 4 buttons that had the current searched month, previous month and the next two months
>he comes up with this (javascript)
vm.mapMonths = [
{key:"gennaio", value:"01"}, {key:"febbraio", value:"02"}, {key:"marzo", value:"03"}, {key:"aprile", value:"04"}, {key:"maggio", value:"05"}, {key:"giugno", value:"06"},
{key:"luglio", value:"07"}, {key:"agosto", value:"08"}, {key:"settembre", value:"09"}, {key:"ottobre", value:"10"}, {key:"novembre", value:"11"}, {key:"dicembre", value:"12"}
];
monthPrev = moment(dateFromCopy).subtract(1, 'M').format('DD MMMM YYYY');
keyMonthPrev = monthPrev.substring(3, monthPrev.length);
valueMonthPrev = monthPrev.substring(3, monthPrev.length - 5);
monthCurrent = moment(dateFromCopy).format('DD MMMM YYYY');
keyMonthCurrent = monthCurrent.substring(3, monthCurrent.length);
valueMonthCurrent = monthCurrent.substring(3, monthCurrent.length - 5);
monthNext = moment(dateFromCopy).add(1, 'M').format('DD MMMM YYYY');
keyMonthNext = monthNext.substring(3, monthNext.length);
valueMonthNext = monthNext.substring(3, monthNext.length - 5);
monthNextNext = moment(dateFromCopy).add(2, 'M').format('DD MMMM YYYY');
keyMontNextNext = monthNextNext.substring(3, monthNextNext.length);
valueMonthNextNext = monthNextNext.substring(3, monthNextNext.length - 5);
vm.months = [
{key:keyMonthPrev, value:valueMonthPrev}, {key:keyMonthCurrent, value:valueMonthCurrent}, {key:keyMonthNext, value:valueMonthNext},
{key:keyMontNextNext, value:valueMonthNextNext}
];
This is probably getting him put in helpdesk. Any of you want to share some coding fails